20231088/vllm
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

[Bugfix] Fix args in benchmark_serving (#3836)

Browse Source 
Co-authored-by: Roger Wang <ywang@roblox.com>
This commit is contained in:
Chang Su 2024-04-04 00:41:05 -07:00 committed by GitHub
parent aabe8f40f2
commit 819a309c0f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 13 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
benchmarks/benchmark_serving.py
View File

@ -110,7 +110,9 @@ def sample_sonnet_requests(
prefix_len: int, prefix_len: int,
tokenizer: PreTrainedTokenizerBase, tokenizer: PreTrainedTokenizerBase,
) -> List[Tuple[str, str, int, int]]: ) -> List[Tuple[str, str, int, int]]:
assert input_len > prefix_len, "input_len must be greater than prefix_len." assert (
input_len > prefix_len
), "'args.sonnet-input-len' must be greater than 'args.prefix-input-len'."
# Load the dataset. # Load the dataset.
with open(dataset_path) as f: with open(dataset_path) as f:
@ -131,8 +133,9 @@ def sample_sonnet_requests(
base_message, add_generation_prompt=True, tokenize=False) base_message, add_generation_prompt=True, tokenize=False)
base_prompt_offset = len(tokenizer(base_prompt_formatted).input_ids) base_prompt_offset = len(tokenizer(base_prompt_formatted).input_ids)
assert (input_len > base_prompt_offset assert (
), f"Please set 'args.input-len' higher than {base_prompt_offset}." input_len > base_prompt_offset
), f"Please set 'args.sonnet-input-len' higher than {base_prompt_offset}."
num_input_lines = round( num_input_lines = round(
(input_len - base_prompt_offset) / average_poem_len) (input_len - base_prompt_offset) / average_poem_len)
@ -140,7 +143,7 @@ def sample_sonnet_requests(
# prompt are fixed poem lines. # prompt are fixed poem lines.
assert ( assert (
prefix_len > base_prompt_offset prefix_len > base_prompt_offset
), f"Please set 'args.prefix-len' higher than {base_prompt_offset}." ), f"Please set 'args.sonnet-prefix-len' higher than {base_prompt_offset}."
num_prefix_lines = round( num_prefix_lines = round(
(prefix_len - base_prompt_offset) / average_poem_len) (prefix_len - base_prompt_offset) / average_poem_len)
@ -373,9 +376,9 @@ def main(args: argparse.Namespace):
input_requests = sample_sonnet_requests( input_requests = sample_sonnet_requests(
dataset_path=args.dataset_path, dataset_path=args.dataset_path,
num_requests=args.num_prompts, num_requests=args.num_prompts,
input_len=args.input_len, input_len=args.sonnet_input_len,
output_len=args.output_len, output_len=args.sonnet_output_len,
prefix_len=args.prefix_len, prefix_len=args.sonnet_prefix_len,
tokenizer=tokenizer, tokenizer=tokenizer,
) )
input_requests = [(prompt, prompt_len, output_len) input_requests = [(prompt, prompt_len, output_len)
@ -388,9 +391,9 @@ def main(args: argparse.Namespace):
input_requests = sample_sonnet_requests( input_requests = sample_sonnet_requests(
dataset_path=args.dataset_path, dataset_path=args.dataset_path,
num_requests=args.num_prompts, num_requests=args.num_prompts,
input_len=args.input_len, input_len=args.sonnet_input_len,
output_len=args.output_len, output_len=args.sonnet_output_len,
prefix_len=args.prefix_len, prefix_len=args.sonnet_prefix_len,
tokenizer=tokenizer, tokenizer=tokenizer,
) )
input_requests = [(prompt_formatted, prompt_len, output_len) input_requests = [(prompt_formatted, prompt_len, output_len)